Add Vizdataset type #993
Add Vizdataset type #993
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
force-pushed
the
viz-datatype
branch
2 times, most recently
from
f7d49c8 to
fd01b14
Compare
hanbyul-here
force-pushed
the
viz-datatype
branch
from
fd01b14 to
5e236ed
Compare
| settings: TimelineDatasetSettings; | ||
| analysis: TimelineDatasetAnalysisIdle; |
There was a problem hiding this comment.
Curious, what is the goal here? To create a new type to just separate out analysis or to eventually move towards having a clear separation between these Viz & timelinedataset types? If the first, wondering why not something like type VizDatasetIdle = Omit<TimelineDatasetIdle, "analysis"> ?
There was a problem hiding this comment.
The goal is to establish the type with attributes only for visualization (for the components needing map visualization), so we can use TimelineDatasets only for Timeline Datasets. (And all other components that only need visualizations - BlockMap, ScrollyMap, s-explore map can use VizDataset)
I think either the current approach or type VizDatasetIdle = Omit<TimelineDatasetIdle, "analysis"> as you suggested works. But in my mind, VizDataset is a more fundamental block and TimelineDataset is the type derived from it - so VizDataset + analysis = TimelineDataset rather than TimelineDataset - analysis = VizDataset.
|
Merging this to try and use it for 967 |
This PR sets up the base datatype for visualization, so the types can be used for all the map-related components with the new Map component. (instead of TimelineDataset)